Prepare accessor function descriptors for properties: get set #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-properties
branch
2 times, most recently
from
20e3f76 to
9ca8ff6
Compare
ktoso
commented
Oct 8, 2024
| @@ -122,7 +122,8 @@ let package = Package( | |||
| dependencies: [ | |||
| .package(url: "https://github.com/swiftlang/swift-syntax.git", branch: "main"), | |||
| .package(url: "https://github.com/apple/swift-argument-parser", from: "1.5.0"), | |||
| .package(url: "https://github.com/apple/swift-system", from: "1.0.0"), | |||
| .package(url: "https://github.com/apple/swift-system", from: "1.0.0"), // TODO: remove, we should not need 'nm' or process callouts | |||
| .package(url: "https://github.com/apple/swift-collections.git", .upToNextMinor(from: "1.1.0")), | |||
There was a problem hiding this comment.
OrderedSet to avoid sourcegen order breaking some tests
ktoso
commented
Oct 8, 2024
| } | ||
|
|
||
| @Test | ||
| @DisabledOnOs(OS.LINUX) // FIXME: enable on Linux when we get new compiler with mangled names in swift interfaces |
There was a problem hiding this comment.
Lots of tests waiting on #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started progress on variables/properties.
Just the function descriptors for now, will do the complete thing in this PR.
Resolves #24